pan3793 commented on PR #36784: URL: https://github.com/apache/spark/pull/36784#issuecomment-1148900904
Thanks for ping me, I think the current `LdapAuthenticationProviderImpl` comes from a very old version of Hive w/o UT, so the exsiting UT can not cover your change. The `LdapAuthenticationProviderImpl` of Spark lacks a lot of functions(including this PR propose to add) comparing to Hive master code, I'm not sure if the Spark community has plan to sync the code and add more UT for STS. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
