HeartSaVioR commented on code in PR #36704:
URL: https://github.com/apache/spark/pull/36704#discussion_r891827819
##########
connector/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchSourceSuite.scala:
##########
@@ -666,9 +667,10 @@ abstract class KafkaMicroBatchSourceSuiteBase extends
KafkaSourceSuiteBase {
testUtils.sendMessages(topic2, Array("6"))
},
StartStream(),
- ExpectFailure[IllegalStateException](e => {
+ ExpectFailure[SparkException](e => {
+ assert(e.asInstanceOf[SparkThrowable].getErrorClass ===
"INTERNAL_ERROR")
// The offset of `topic2` should be changed from 2 to 1
- assert(e.getMessage.contains("was changed from 2 to 1"))
+ assert(e.getCause.getMessage.contains("was changed from 2 to 1"))
Review Comment:
https://docs.oracle.com/javase/8/docs/api/java/lang/IllegalStateException.html
> Signals that a method has been invoked at an illegal or inappropriate
time. In other words, the Java environment or Java application is not in an
appropriate state for the requested operation.
It's arguable what is the "state" of the application. If the state of the
application is dependent on the external system (like this), this statement
sounds to me to be valid.
If Spark project wants to restrict the usage of IllegalStateException to
only denote the possible internal error then that is fair, but would be great
if we do not rely on "convention" (that's a magic word everyone can claim the
different things with the same word) and explicitly mention it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
