[GitHub] [spark] thejdeep commented on a diff in pull request #36165: [SPARK-36620][SHUFFLE] Add Push Based Shuffle client side metrics

[GitBox]

thejdeep commented on code in PR #36165:
URL: https://github.com/apache/spark/pull/36165#discussion_r1010566832


##########
core/src/main/scala/org/apache/spark/status/storeTypes.scala:
##########
@@ -138,6 +138,16 @@ private[spark] object TaskIndexNames {
   final val SHUFFLE_WRITE_RECORDS = "swr"
   final val SHUFFLE_WRITE_SIZE = "sws"
   final val SHUFFLE_WRITE_TIME = "swt"
+  final val PUSH_BASED_SHUFFLE_CORRUPT_MERGED_BLOCK_CHUNKS = "scmbc"
+  final val PUSH_BASED_SHUFFLE_FALLBACK_COUNT = "sfc"
+  final val PUSH_BASED_SHUFFLE_MERGED_REMOTE_BLOCKS = "smrb"
+  final val PUSH_BASED_SHUFFLE_MERGED_LOCAL_BLOCKS = "smlb"
+  final val PUSH_BASED_SHUFFLE_MERGED_REMOTE_CHUNKS = "smrc"
+  final val PUSH_BASED_SHUFFLE_MERGED_LOCAL_CHUNKS = "smlc"
+  final val PUSH_BASED_SHUFFLE_MERGED_REMOTE_READS = "smrr"
+  final val PUSH_BASED_SHUFFLE_MERGED_LOCAL_READS = "smlr"
+  final val PUSH_BASED_SHUFFLE_REMOTE_REQS_DURATION = "srrd"
+  final val PUSH_BASED_SHUFFLE_MERGED_REMOTE_REQS_DURATION = "smrrd"

Review Comment:
   Added prefix, thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org