maryannxue commented on code in PR #38558: URL: https://github.com/apache/spark/pull/38558#discussion_r1017328200
########## sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala: ########## @@ -209,6 +209,19 @@ case class AdaptiveSparkPlanExec( override def output: Seq[Attribute] = inputPlan.output + // Try our best to give a stable output partitioning and ordering. Review Comment: This would be super limited use... and cause inconsistency. I'd only return output partitioning if there is a user repartition op in the end. In other words, only if AQE plan is required to preserve user specified partitioning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org