rangadi commented on code in PR #43023:
URL: https://github.com/apache/spark/pull/43023#discussion_r1332415585
##########
core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala:
##########
@@ -184,10 +185,20 @@ private[spark] class PythonWorkerFactory(
redirectStreamsToStderr(workerProcess.getInputStream,
workerProcess.getErrorStream)
// Wait for it to connect to our socket, and validate the auth secret.
- serverSocketChannel.socket().setSoTimeout(10000)
Review Comment:
There was supposed to be 10 second timeout. But this call does not seem to
affect `serverSocketChannel.accept()`.
This set might only take effect if we did
`serverSocketChannel.socket().accept()`, but hat returns a socket, not a
channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
