cloud-fan commented on code in PR #43010: URL: https://github.com/apache/spark/pull/43010#discussion_r1332483781
########## python/pyspark/sql/connect/plan.py: ########## @@ -1197,6 +1197,7 @@ def plan(self, session: "SparkConnectClient") -> proto.Relation: plan.collect_metrics.input.CopyFrom(self._child.plan(session)) plan.collect_metrics.name = self._name plan.collect_metrics.metrics.extend([self.col_to_expr(x, session) for x in self._exprs]) + plan.collect_metrics.dataframe_id = self._child._plan_id Review Comment: does Spark Connect DataFrame also have the unique id? cc @HyukjinKwon @zhengruifeng -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org