cloud-fan commented on code in PR #42612:
URL: https://github.com/apache/spark/pull/42612#discussion_r1332486360
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala:
##########
@@ -270,6 +271,8 @@ object SerializerSupport {
* non-null value.
* @param isDeterministic Whether the method invocation is deterministic or
not. If false, Spark
* will not apply certain optimizations such as
constant folding.
+ * @param scalarFunction the [[ScalarFunction]] object if this is calling the
magic method of the
+ * [[ScalarFunction]] otherwise is unset.
*/
case class StaticInvoke(
Review Comment:
we can override `stringArgs` in `StaticInvoke`, to exclude the new parameter
if it's None, to avoid the golden file changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
