zhaomin1423 commented on code in PR #43502: URL: https://github.com/apache/spark/pull/43502#discussion_r1392669927
########## common/kvstore/src/main/java/org/apache/spark/util/kvstore/LevelDBIterator.java: ########## @@ -182,23 +193,36 @@ public boolean skip(long n) { @Override public synchronized void close() throws IOException { - db.notifyIteratorClosed(this); + db.notifyIteratorClosed(it); if (!closed) { - it.close(); - closed = true; - next = null; + try { + it.close(); + } catch (UncheckedIOException uncheckedIOException) { Review Comment: thanks,done ########## common/kvstore/src/main/java/org/apache/spark/util/kvstore/LevelDBIterator.java: ########## @@ -182,23 +193,36 @@ public boolean skip(long n) { @Override public synchronized void close() throws IOException { - db.notifyIteratorClosed(this); + db.notifyIteratorClosed(it); if (!closed) { - it.close(); - closed = true; - next = null; + try { + it.close(); + } catch (UncheckedIOException uncheckedIOException) { Review Comment: thanks,done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org