LuciferYang commented on code in PR #43818:
URL: https://github.com/apache/spark/pull/43818#discussion_r1394365136
##########
dev/sparktestsupport/modules.py:
##########
@@ -178,7 +178,7 @@ def __hash__(self):
core = Module(
name="core",
- dependencies=[kvstore, network_common, network_shuffle, unsafe, launcher],
+ dependencies=[kvstore, network_common, network_shuffle, unsafe, launcher,
utils],
Review Comment:
cc @zhengruifeng @HyukjinKwon , `utils` module is also a direct dependency
of unsafe and network-common. Do we need to modify the dependencies of `unsafe`
and `network-common`? Or is the current change sufficient?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
