tgravescs commented on code in PR #43627:
URL: https://github.com/apache/spark/pull/43627#discussion_r1394837773
##########
core/src/main/scala/org/apache/spark/SparkEnv.scala:
##########
@@ -415,6 +418,11 @@ object SparkEnv extends Logging {
advertiseAddress, blockManagerPort, numUsableCores,
blockManagerMaster.driverEndpoint)
// NB: blockManager is not valid until initialize() is called later.
+ // SPARK-45762 introduces a change where the ShuffleManager is
initialized later
+ // in the SparkContext and Executor, to allow for custom
ShuffleManagers defined
+ // in user jars. In the executor, the BlockManager uses a lazy val to
obtain the
+ // shuffleManager from the SparkEnv. In the driver, the SparkEnv's
shuffleManager
Review Comment:
I think this comment it no longer true. Driver SparkEnv shufflemanager is
created after the plugin initialized.
##########
core/src/main/scala/org/apache/spark/SparkEnv.scala:
##########
@@ -71,6 +70,12 @@ class SparkEnv (
val outputCommitCoordinator: OutputCommitCoordinator,
val conf: SparkConf) extends Logging {
+ // We initialize the ShuffleManager later in SparkContext, and Executor, to
allow
Review Comment:
```suggestion
// We initialize the ShuffleManager later in SparkContext and Executor to
allow
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
