LuciferYang commented on code in PR #43502:
URL: https://github.com/apache/spark/pull/43502#discussion_r1396681491
##########
common/kvstore/src/main/java/org/apache/spark/util/kvstore/LevelDBIterator.java:
##########
@@ -280,4 +302,43 @@ static int compare(byte[] a, byte[] b) {
return a.length - b.length;
}
+ static class ResourceCleaner implements Runnable {
+
+ private final DBIterator dbIterator;
+
+ private final LevelDB levelDB;
+
+ private final AtomicBoolean started = new AtomicBoolean(true);
+
+ ResourceCleaner(DBIterator dbIterator, LevelDB levelDB) {
+ this.dbIterator = dbIterator;
+ this.levelDB = levelDB;
+ }
+
+ @Override
+ public void run() {
+ if (started.compareAndSet(true, false)) {
+ levelDB.notifyIteratorClosed(dbIterator);
+ synchronized (levelDB.getLevelDB()) {
+ DB _db = levelDB.getLevelDB().get();
+ if (_db != null) {
+ try {
+ dbIterator.close();
+ } catch (IOException e) {
+ throw new UncheckedIOException(e);
Review Comment:
nit: Personally, perhaps printing a log is enough, as there should be no
other places capturing this exception now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
