uros-db opened a new pull request, #45422:
URL: https://github.com/apache/spark/pull/45422
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
Currently, all `StringType` arguments passed to built-in string functions in
Spark SQL get treated as binary strings. This behaviour is incorrect for almost
all collationIds except the default (0), and we should instead warn the user if
they try to use an unsupported collation for the given function. Over time, we
should implement the appropriate support for these (function, collation) pairs,
but until then - we should have a way to fail unsupported statements in query
analysis.
### Does this PR introduce _any_ user-facing change?
Yes, users will now get appropriate errors when they try to use an
unsupported collation with a given string function.
### How was this patch tested?
Tests in CollationSuite to check if these functions work for binary
collations and throw exceptions for others.
### Was this patch authored or co-authored using generative AI tooling?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
