uros-db commented on code in PR #45421:
URL: https://github.com/apache/spark/pull/45421#discussion_r1517229022
##########
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##########
@@ -410,7 +412,9 @@ public boolean endsWith(final UTF8String suffix, int
collationId) {
if (collationId == CollationFactory.LOWERCASE_COLLATION_ID) {
return this.toLowerCase().endsWith(suffix.toLowerCase());
}
- return matchAt(suffix, numBytes - suffix.numBytes, collationId);
+ if (suffix.numBytes == 0 || this.numBytes == 0) return suffix.numBytes==0;
+
+ return CollationFactory.getStringSearch(this, suffix,
collationId).last()==this.numChars()-suffix.numChars();
Review Comment:
for clarity, I think we can separate this out into `private boolean
collatedEndsWith`
##########
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##########
@@ -410,7 +412,9 @@ public boolean endsWith(final UTF8String suffix, int
collationId) {
if (collationId == CollationFactory.LOWERCASE_COLLATION_ID) {
return this.toLowerCase().endsWith(suffix.toLowerCase());
}
- return matchAt(suffix, numBytes - suffix.numBytes, collationId);
+ if (suffix.numBytes == 0 || this.numBytes == 0) return suffix.numBytes==0;
+
+ return CollationFactory.getStringSearch(this, suffix,
collationId).last()==this.numChars()-suffix.numChars();
Review Comment:
for clarity, I think we can separate this out into `private boolean
collatedEndsWith(...)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
