ueshin commented on code in PR #45468:
URL: https://github.com/apache/spark/pull/45468#discussion_r1520516470
##########
core/src/main/scala/org/apache/spark/SparkEnv.scala:
##########
@@ -141,20 +141,22 @@ class SparkEnv (
pythonExec: String,
workerModule: String,
daemonModule: String,
- envVars: Map[String, String]): (PythonWorker, Option[Long]) = {
+ envVars: Map[String, String],
+ useDaemon: Boolean = conf.get(Python.PYTHON_USE_DAEMON)): (PythonWorker,
Option[Long]) = {
synchronized {
val key = PythonWorkersKey(pythonExec, workerModule, daemonModule,
envVars)
- pythonWorkers.getOrElseUpdate(key,
- new PythonWorkerFactory(pythonExec, workerModule, daemonModule,
envVars)).create()
+ pythonWorkers.getOrElseUpdate(key, new PythonWorkerFactory(
+ pythonExec, workerModule, daemonModule, envVars, useDaemon)).create()
}
}
private[spark] def createPythonWorker(
pythonExec: String,
workerModule: String,
- envVars: Map[String, String]): (PythonWorker, Option[Long]) = {
+ envVars: Map[String, String],
+ useDaemon: Boolean): (PythonWorker, Option[Long]) = {
Review Comment:
This should have the default value, too?
##########
core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala:
##########
@@ -47,7 +47,8 @@ private[spark] class PythonWorkerFactory(
pythonExec: String,
workerModule: String,
daemonModule: String,
- envVars: Map[String, String])
+ envVars: Map[String, String],
+ useDaemonEnabled: Boolean = SparkEnv.get.conf.get(PYTHON_USE_DAEMON))
Review Comment:
This shouldn't have the default value? Let's make the caller side decide
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
