HeartSaVioR commented on code in PR #45341: URL: https://github.com/apache/spark/pull/45341#discussion_r1520688468
########## sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/MapStateSuite.scala: ########## @@ -67,6 +67,7 @@ class MapStateSuite extends StateVariableSuiteBase { assert(!testState.exists()) assert(testState.getMap().hasNext === false) } + ImplicitGroupingKeyTracker.removeImplicitKey() Review Comment: Maybe just do this in setup (before) or teardown (after) in StateVariableSuiteBase, to ensure the cleanup is guaranteed to be done - as failure in test A won't clean up the thread local and introduce another failure. We do like to avoid cascading failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org