dongjoon-hyun commented on PR #46226: URL: https://github.com/apache/spark/pull/46226#issuecomment-2078584110
> > Ya, for those intersection cases, it's controversial like we discussed here. > > As you said, each test cases in DataFrameWindowFramesSuite tests window function too. We should determine the focus of the test cases. I got it. So your point is that `WindowFrame` is a subset of `WindowFunction`, right? Consequently, `DataFrameWindowFramesSuite` is better because it's more specific. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
