mihailom-db commented on code in PR #46206:
URL: https://github.com/apache/spark/pull/46206#discussion_r1580518571
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java:
##########
@@ -306,6 +308,258 @@ public static int execICU(final UTF8String string, final
UTF8String substring,
}
}
+ public static class StringTrim {
+ public static UTF8String exec(
+ final UTF8String srcString,
+ final int collationId) {
+ CollationFactory.Collation collation =
CollationFactory.fetchCollation(collationId);
+ if (collation.supportsBinaryEquality) {
+ return execBinary(srcString);
+ } else if (collation.supportsLowercaseEquality) {
+ return execLowercase(srcString);
+ } else {
+ return execICU(srcString, collationId);
+ }
+ }
+ public static UTF8String exec(
+ final UTF8String srcString,
+ final UTF8String trimString,
+ final int collationId) {
+ CollationFactory.Collation collation =
CollationFactory.fetchCollation(collationId);
+ if (collation.supportsBinaryEquality) {
+ return execBinary(srcString, trimString);
+ } else if (collation.supportsLowercaseEquality) {
+ return execLowercase(srcString, trimString);
+ } else {
+ return execICU(srcString, trimString, collationId);
+ }
+ }
+ public static String genCode(
+ final String srcString,
+ final int collationId) {
+ CollationFactory.Collation collation =
CollationFactory.fetchCollation(collationId);
+ String expr = "CollationSupport.StringTrim.exec";
+ if (collation.supportsBinaryEquality) {
+ return String.format(expr + "Binary(%s)", srcString);
+ } else if (collation.supportsLowercaseEquality) {
+ return String.format(expr + "Lowercase(%s)", srcString);
+ } else {
+ return String.format(expr + "ICU(%s, %d)", srcString, collationId);
+ }
+ }
+ public static String genCode(
+ final String srcString,
+ final String trimString,
+ final int collationId) {
+ CollationFactory.Collation collation =
CollationFactory.fetchCollation(collationId);
+ String expr = "CollationSupport.StringTrim.exec";
+ if (collation.supportsBinaryEquality) {
+ return String.format(expr + "Binary(%s, %s)", srcString, trimString);
+ } else if (collation.supportsLowercaseEquality) {
+ return String.format(expr + "Lowercase(%s, %s)", srcString,
trimString);
+ } else {
+ return String.format(expr + "ICU(%s, %s, %d)", srcString, trimString,
collationId);
+ }
+ }
+ public static UTF8String execBinary(
+ final UTF8String srcString) {
+ return srcString.trim();
+ }
+ public static UTF8String execBinary(
+ final UTF8String srcString,
+ final UTF8String trimString) {
+ return srcString.trim(trimString);
+ }
+ public static UTF8String execLowercase(
+ final UTF8String srcString) {
+ return srcString.trim();
Review Comment:
Shouldn't this be for a space character trim? ' ' is the same for lowercase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
