09306677806 commented on PR #46241:
URL: https://github.com/apache/spark/pull/46241#issuecomment-2078978391
bc1q2tk3c4z7zvjxhswrdpqt7xp98ea99h29zu9qyh
________________________________
From: Uros Bojanic ***@***.***>
Sent: Friday, April 26, 2024 12:43:57 PM
To: apache/spark ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [apache/spark] [WIP][SPARK-48003][SQL] Add collation support for
hll sketch aggregate (PR #46241)
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
________________________________
You can view, comment on, or merge this pull request online at:
https://github.com/apache/spark/pull/46241
Commit Summary
*
19985e7<https://github.com/apache/spark/pull/46241/commits/19985e746622ccea9db11cee67fbb0f44e255454>
Initial commit
File Changes
(3 files<https://github.com/apache/spark/pull/46241/files>)
* M
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java<https://github.com/apache/spark/pull/46241/files#diff-640c14aa5d7473df79b2435ce5a327dffcc16ca29354b153956b4f8d19fdb16c>
(13)
* M
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/datasketchesAggregates.scala<https://github.com/apache/spark/pull/46241/files#diff-b018f926986992b319f22d8beb29c63c4d1d66fb949624f0187e2065d60e15d1>
(8)
* M
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala<https://github.com/apache/spark/pull/46241/files#diff-ee10cc9f2a8b81bab1454ca6e673e1b50905a37e1036a7f5fcbac8deb94cc665>
(19)
Patch Links:
* https://github.com/apache/spark/pull/46241.patch
* https://github.com/apache/spark/pull/46241.diff
—
Reply to this email directly, view it on
GitHub<https://github.com/apache/spark/pull/46241>, or
unsubscribe<https://github.com/notifications/unsubscribe-auth/ANEZZRBHIZBVARBTV52O6ILY7ILFLAVCNFSM6AAAAABG2NDKX6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGI3DKMZSG43DKNA>.
You are receiving this because you are subscribed to this thread.Message ID:
***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
