cloud-fan commented on code in PR #46209:
URL: https://github.com/apache/spark/pull/46209#discussion_r1580908359
##########
sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala:
##########
@@ -4715,6 +4715,145 @@ class SQLQuerySuite extends QueryTest with
SharedSparkSession with AdaptiveSpark
val df6 = df3.join(df2, col("df3.zaak_id") === col("df2.customer_id"),
"outer")
df5.crossJoin(df6)
}
+
+ test("SPARK-47939: Describe should work with parameterized queries") {
+ checkAnswer(
+ spark.sql("describe select ?", Array(1)),
+ Array(
+ Row("1", "int", null)
+ )
+ )
+ checkAnswer(
+ spark.sql("describe select :first", Map("first" -> 1)),
+ Array(
+ Row("1", "int", null)
+ )
+ )
+
+ checkAnswer(
+ spark.sql("describe select * from values (?, ?) t(x, y)", Array(1, "a")),
+ Array(
+ Row("x", "int", null),
+ Row("y", "string", null)
+ )
+ )
+ checkAnswer(
+ spark.sql(
+ "describe select * from values (:first, :second) t(x, y)",
+ Map("first" -> 1, "second" -> "a")
+ ),
+ Array(
+ Row("x", "int", null),
+ Row("y", "string", null)
+ )
+ )
+ }
+
+ test("SPARK-47939: Explain should work with parameterized queries") {
+ def checkQueryPlan(df: DataFrame, plan: String): Unit = assert(
+ df.collect()
+ .map(_.getString(0))
+ .map(_.replaceAll("#[0-9]+", "#N"))
+ .sameElements(Array(plan))
+ )
+
+ checkQueryPlan(
+ spark.sql("explain select ?", Array(1)),
+ """== Physical Plan ==
Review Comment:
nit: use `stripMargin`
```
"""
|line1
|line2
""".stripMargin
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
