yaooqinn commented on code in PR #46244:
URL: https://github.com/apache/spark/pull/46244#discussion_r1581202258
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/MsSQLServerDatabaseOnDocker.scala:
##########
@@ -28,5 +28,6 @@ class MsSQLServerDatabaseOnDocker extends DatabaseOnDocker {
override val jdbcPort: Int = 1433
override def getJdbcUrl(ip: String, port: Int): String =
- s"jdbc:sqlserver://$ip:$port;user=sa;password=Sapass123;"
+ s"jdbc:sqlserver://$ip:$port;user=sa;password=Sapass123;" +
+ "encrypt=true;trustServerCertificate=true"
Review Comment:
Yeah, I referred and confirmed with ms-jdbc docs, which says it's
recommended for testing purposes. I didn't investigate thoroughly when this
change for default values was applied due to the large version span.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
