Re: [PR] [SPARK-48042][SQL] Use a timestamp formatter with timezone at class level instead of making copies at method level [spark]

[via GitHub]

yaooqinn commented on code in PR #46282:
URL: https://github.com/apache/spark/pull/46282#discussion_r1583426022


##########
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/TimestampFormatter.scala:
##########
@@ -159,8 +159,10 @@ class Iso8601TimestampFormatter(
     isParsing: Boolean)
   extends TimestampFormatter with DateTimeFormatterHelper {
   @transient
-  protected lazy val formatter: DateTimeFormatter =
-    getOrCreateFormatter(pattern, locale, isParsing)
+  protected lazy val formatter: DateTimeFormatter = 
getOrCreateFormatter(pattern, locale, isParsing)

Review Comment:
   addressed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org