dongjoon-hyun commented on code in PR #46279:
URL: https://github.com/apache/spark/pull/46279#discussion_r1583520879
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TableOutputResolver.scala:
##########
@@ -219,7 +221,7 @@ object TableOutputResolver extends SQLConfHelper with
Logging {
fillDefaultValue: Boolean = false): Seq[NamedExpression] = {
val matchedCols = mutable.HashSet.empty[String]
val reordered = expectedCols.flatMap { expectedCol =>
- val matched = inputCols.filter(col => conf.resolver(col.name,
expectedCol.name))
+ val matched = inputCols.filter(col => resolver(col.name,
expectedCol.name))
Review Comment:
This `conf` is given by the method parameter. I'm not sure this is correct
optimization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
