panbingkun commented on PR #43706: URL: https://github.com/apache/spark/pull/43706#issuecomment-2084240278
I think there is no problem with the overall logic, but I am a little worried about the `UUID generation`. I suggest using `python` to generate `UUID`, because in our native logic, we have used `python` to generate `SPARK_HOME`, This is to eliminate dependence on the outside, WDYT? @HyukjinKwon @LuciferYang https://github.com/apache/spark/blob/da92293f9ce0be1ac283c4a5d769af550abf7031/bin/find-spark-home.cmd#L21-L59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
