dongjoon-hyun commented on code in PR #46266:
URL: https://github.com/apache/spark/pull/46266#discussion_r1585541176
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcReadBenchmark.scala:
##########
@@ -79,6 +79,12 @@ object OrcReadBenchmark extends SqlBasedBenchmark {
spark.read.format(HIVE_ORC_FORMAT).load(dirORC).createOrReplaceTempView("hiveOrcTable")
}
+ private def getExpr(dataType: DataType = IntegerType): String = dataType
match {
+ case ByteType => "cast(value % 128 as byte)"
+ case ShortType => "cast(value % 32768 as short)"
+ case _ => s"cast(value % ${Int.MaxValue} as ${dataType.sql})"
+ }
Review Comment:
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
