HyukjinKwon commented on code in PR #46306: URL: https://github.com/apache/spark/pull/46306#discussion_r1585756031
########## python/pyspark/sql/tests/test_python_streaming_datasource.py: ########## @@ -136,6 +137,33 @@ def streamWriter(self, schema, overwrite): return TestDataSource + def _get_simple_data_source(self): Review Comment: Maybe just define this class and directly pass `SimpleDataSource` to `register`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org