HyukjinKwon commented on PR #46298:
URL: https://github.com/apache/spark/pull/46298#issuecomment-2087905857

   For my own notes:
   
   Tests being skipped for now
   
   ```
   ======================================================================
   ERROR [1.120s]: test_save_load 
(pyspark.ml.tests.connect.test_connect_classification.ClassificationTestsOnConnect.test_save_load)
   ----------------------------------------------------------------------
   Traceback (most recent call last):
     File 
"/home/runner/work/spark/spark-3.5/python/pyspark/ml/tests/connect/test_legacy_mode_classification.py",
 line 144, in test_save_load
       estimator.save(fs_path)
     File 
"/home/runner/work/spark/spark-3.5/python/pyspark/ml/connect/io_utils.py", line 
248, in save
       _copy_dir_from_local_to_fs(tmp_local_dir, path)
     File 
"/home/runner/work/spark/spark-3.5/python/pyspark/ml/connect/io_utils.py", line 
57, in _copy_dir_from_local_to_fs
       _copy_file_from_local_to_fs(file_path, dest_file_path)
     File 
"/home/runner/work/spark/spark-3.5/python/pyspark/ml/connect/io_utils.py", line 
39, in _copy_file_from_local_to_fs
       session.copyFromLocalToFs(local_path, dest_path)
     File 
"/home/runner/work/spark/spark-3.5/python/pyspark/sql/connect/session.py", line 
756, in copyFromLocalToFs
       self._client.copy_from_local_to_fs(local_path, dest_path)
     File 
"/home/runner/work/spark/spark-3.5/python/pyspark/sql/connect/client/core.py", 
line 1549, in copy_from_local_to_fs
       self._artifact_manager._add_forward_to_fs_artifacts(local_path, 
dest_path)
     File 
"/home/runner/work/spark/spark-3.5/python/pyspark/sql/connect/client/artifact.py",
 line 280, in _add_forward_to_fs_artifacts
       self._request_add_artifacts(requests)
     File 
"/home/runner/work/spark/spark-3.5/python/pyspark/sql/connect/client/artifact.py",
 line 259, in _request_add_artifacts
       response: proto.AddArtifactsResponse = self._retrieve_responses(requests)
                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     File 
"/home/runner/work/spark/spark-3.5/python/pyspark/sql/connect/client/artifact.py",
 line 256, in _retrieve_responses
       return self._stub.AddArtifacts(requests, metadata=self._metadata)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     File 
"/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/grpc/_channel.py",
 line 1536, in __call__
       return _end_unary_response_blocking(state, call, False, None)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     File 
"/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/grpc/_channel.py",
 line 1006, in _end_unary_response_blocking
       raise _InactiveRpcError(state)  # pytype: disable=not-instantiable
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated 
with:
        status = StatusCode.INTERNAL
        details = "Uploading artifact file to local file system destination 
path is not supported."
        debug_error_string = "UNKNOWN:Error received from peer  
{grpc_message:"Uploading artifact file to local file system destination path is 
not supported.", grpc_status:13, 
created_time:"2024-05-01T03:01:32.[558](https://github.com/HyukjinKwon/spark/actions/runs/8904629949/job/24454181142#step:9:559)489983+00:00"}"
   >
   ======================================================================
   FAIL [24.378s]: test_binary_classes_logistic_regression 
(pyspark.ml.tests.connect.test_connect_classification.ClassificationTestsOnConnect.test_binary_classes_logistic_regression)
   ----------------------------------------------------------------------
   Traceback (most recent call last):
     File 
"/home/runner/work/spark/spark-3.5/python/pyspark/ml/tests/connect/test_legacy_mode_classification.py",
 line 81, in test_binary_classes_logistic_regression
       self._check_result(result, expected_predictions, expected_probabilities)
     File 
"/home/runner/work/spark/spark-3.5/python/pyspark/ml/tests/connect/test_legacy_mode_classification.py",
 line 41, in _check_result
       np.testing.assert_allclose(
     File 
"/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/numpy/testing/_private/utils.py",
 line 1504, in assert_allclose
       assert_array_compare(compare, actual, desired, err_msg=str(err_msg),
     File 
"/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/contextlib.py", line 81, 
in inner
       return func(*args, **kwds)
              ^^^^^^^^^^^^^^^^^^^
     File 
"/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/numpy/testing/_private/utils.py",
 line 797, in assert_array_compare
       raise AssertionError(msg)
   AssertionError: 
   Not equal to tolerance rtol=0.1, atol=0
   Mismatched elements: 1 / 4 (25%)
   Max absolute difference: 0.03528662
   Max relative difference: 0.22001187
    x: array([[0.217866, 0.782134],
          [0.804328, 
0.19[567](https://github.com/HyukjinKwon/spark/actions/runs/8904629949/job/24454181142#step:9:568)2]])
    y: array([[0.217875, 0.782125],
          [0.839615, 0.160385]])
   ----------------------------------------------------------------------
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to