panbingkun commented on PR #46288: URL: https://github.com/apache/spark/pull/46288#issuecomment-2093048107
@SethTisue Just right, you are here too https://github.com/scala/scala/pull/10717 https://github.com/scala/scala/pull/10717/files#diff-87e6fe6a086cec9825e72357099f0ae6b84800ea025c5aee97b6cc7088c6cd4d I found that in `scala-2.13.14`, the version of `org.jline:jline` was upgraded from `3.14.1` to `3.15.1` because: https://github.com/scala/bug/issues/12957 <img width="1133" alt="image" src="https://github.com/apache/spark/assets/15246973/c4979116-3199-4545-a7c0-d189ed170866";> But I found that `org.jline:jline:3.15.1` is compiled based on `JDK 21`. <img width="968" alt="image" src="https://github.com/apache/spark/assets/15246973/a95c0f5f-9174-4ba2-a5bc-65cbf40df0ab";> So the maven plugin `maven-enforcer-plugin` helped us find this issue when Spark upgraded `the scala version` from `2.13.13` to `2.13.14`. Because our current Spark master branch supports `JDK 17` and `JDK 21`. Based on the above reasons, I would like to ask if it is also `reasonable` and `feasible` for us to exclude `org.jline:jline:3.15.1` from `org.scala-lang:scala-compiler:jar:2.13.14`, and explicitly let it use `org.jline:jline:3.14.1`? <img width="572" alt="image" src="https://github.com/apache/spark/assets/15246973/319c0f73-8231-4369-bd66-30a81f3698a4";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
