gengliangwang commented on code in PR #46362:
URL: https://github.com/apache/spark/pull/46362#discussion_r1591860394
##########
core/src/main/scala/org/apache/spark/SparkContext.scala:
##########
@@ -1855,7 +1859,9 @@ class SparkContext(config: SparkConf) extends Logging {
root,
if (uri.getFragment != null) uri.getFragment else source.getName)
logInfo(
- s"Unpacking an archive $path from ${source.getAbsolutePath} to
${dest.getAbsolutePath}")
+ log"Unpacking an archive ${MDC(LogKeys.PATH, path)}" +
+ log" from ${MDC(LogKeys.SOURCE_ABSOLUTE_PATH,
source.getAbsolutePath)}" +
Review Comment:
nit: how about simply `SOURCE_PATH`
##########
core/src/main/scala/org/apache/spark/SparkContext.scala:
##########
@@ -1855,7 +1859,9 @@ class SparkContext(config: SparkConf) extends Logging {
root,
if (uri.getFragment != null) uri.getFragment else source.getName)
logInfo(
- s"Unpacking an archive $path from ${source.getAbsolutePath} to
${dest.getAbsolutePath}")
+ log"Unpacking an archive ${MDC(LogKeys.PATH, path)}" +
+ log" from ${MDC(LogKeys.SOURCE_ABSOLUTE_PATH,
source.getAbsolutePath)}" +
+ log" to ${MDC(LogKeys.DESTINATION_ABSOLUTE_PATH,
dest.getAbsolutePath)}")
Review Comment:
nit: how about simply `DESTINATION_PATH`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
