grundprinzip commented on code in PR #45481:
URL: https://github.com/apache/spark/pull/45481#discussion_r1592074090


##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -1775,6 +1775,10 @@ def _to_table(self) -> Tuple["pa.Table", 
Optional[StructType]]:
         assert table is not None
         return (table, schema)
 
+    def _toArrow(self) -> "pa.Table":

Review Comment:
   @HyukjinKwon I think it would be fine to make this a regular public method 
instead of the `_toArrow` maybe change it to `toArrowTable` to give a better 
indication of the return type.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to