xupefei commented on code in PR #46245:
URL: https://github.com/apache/spark/pull/46245#discussion_r1601524509


##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala:
##########
@@ -205,6 +205,91 @@ object ScalarUserDefinedFunction {
   }
 }
 
+case class UserDefinedAggregationFunction private[sql] (

Review Comment:
   A lot. I just did a refactoring to re-use the ScalarUserDefinedFunction 
proto and most of the Scala code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to