Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/748#discussion_r12665202
--- Diff: core/src/main/scala/org/apache/spark/SparkEnv.scala ---
@@ -296,18 +297,15 @@ object SparkEnv extends Logging {
// System properties that are not java classpaths
val systemProperties = System.getProperties.iterator.toSeq
- val otherProperties = systemProperties.filter { case (k, v) =>
+ val otherProperties = systemProperties.filter { case (k, _) =>
k != "java.class.path" && !k.startsWith("spark.")
}.sorted
// Class paths including all added jars and files
- val classPathProperty = systemProperties.find { case (k, v) =>
- k == "java.class.path"
- }.getOrElse(("", ""))
- val classPathEntries = classPathProperty._2
+ val classPathEntries = javaClassPath
.split(File.pathSeparator)
--- End diff --
Yes, I did, but not within Spark, but outside, in REPL. As a matter of
fact,
[Properties.javaClassPath](https://github.com/scala/scala/blob/2.12.x/src/library/scala/util/Properties.scala#L126)
ends up calling [System.getProperty(name,
alt)](https://github.com/scala/scala/blob/2.12.x/src/library/scala/util/Properties.scala#L52)
so the change is truly a refactoring (to ease reading the class later on).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
