Github user jaceklaskowski commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8762#discussion_r39517063
  
    --- Diff: docs/running-on-yarn.md ---
    @@ -54,8 +54,8 @@ In `yarn-cluster` mode, the driver runs on a different 
machine than the client,
     
     # Preparations
     
    -Running Spark-on-YARN requires a binary distribution of Spark which is 
built with YARN support.
    -Binary distributions can be downloaded from the Spark project website. 
    +Running Spark on YARN requires a binary distribution of Spark which is 
built with YARN support.
    --- End diff --
    
    See 
http://people.apache.org/~pwendell/spark-nightly/spark-master-docs/latest/running-on-yarn.html
 and search for `./bin/spark-submit --class path.to.your.Class`. It renders 
incorrectly since there's the indent + backticks that make the docs go awry. 
That's why I fixed that, too.
    
    What do you propose as *a different approach going forward*? When I see a 
change without changes to the docs, what's the *proper* approach?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to