Github user HyukjinKwon commented on the pull request:

    https://github.com/apache/spark/pull/8718#issuecomment-140569493
  
    It look ok to JDBC datasource tough. I am wondering if conversion from 
`NumericType` to `StringType` should be prevented or treated for each 
differently as it looks unsafe for Parquet and ORC. For example, when column 
`A` is string, `A >100' will push down a filter with string value performing 
string comperison.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to