Github user justinuang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8833#discussion_r39933648
  
    --- Diff: python/pyspark/sql/functions.py ---
    @@ -1414,7 +1414,7 @@ def __init__(self, func, returnType, name=None):
         def _create_judf(self, name):
             f, returnType = self.func, self.returnType  # put them in closure 
`func`
             func = lambda _, it: map(lambda x: returnType.toInternal(f(*x)), 
it)
    -        ser = AutoBatchedSerializer(PickleSerializer())
    +        ser = BatchedSerializer(PickleSerializer(), 100)
    --- End diff --
    
    Can we pull this out in a constant? And also the same value in the Python, 
and put a comment on each saying that they have to equal? It's very dangerous 
if this value goes out of sync.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to