Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/9634#discussion_r44600842
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
---
@@ -336,4 +336,29 @@ class ParquetFilterSuite extends QueryTest with
ParquetTest with SharedSQLContex
}
}
}
+
+ test("actual filter push down") {
+ import testImplicits._
+ withSQLConf(SQLConf.PARQUET_FILTER_PUSHDOWN_ENABLED.key -> "true") {
+ withTempPath { dir =>
+ val path = s"${dir.getCanonicalPath}/part=1"
+ (1 to 3).map(i => (i, i.toString)).toDF("a",
"b").write.parquet(path)
+ val df = sqlContext.read.parquet(path).filter("a = 2")
+
+ // This is the source RDD without Spark-side filtering.
+ val childRDD =
+ df
+ .queryExecution
+
.executedPlan.asInstanceOf[org.apache.spark.sql.execution.Filter]
+ .child.
+ execute()
+
+ // The result should be single row.
+ // When a filter is pushed to Parquet, Parquet can apply it to
eveyr row.
+ // So, we can check the number of rows returned from the Parquet
+ // to make sure our filter pushdown work.
+ assert(childRDD.count == 1)
--- End diff --
Oh, sorry lack of language skills..
I mean the test code checks if filters are really pushed down or not, which
I thought is enough for this issue.
So, after this issue is resolved, I would like to change
`ParqueyFilterSuite` and add some tests for ORC, maybe at a separste issue that
is for properly testing all.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
