Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/9687#issuecomment-157561940
Several things to mention.
Firstly, I wonder if it is okay to put `extractSourceRDDToDataFrame` at
`QueryTest`. I did not put but I think the `extractSourceRDDToDataFrame` can be
shared with `ParquetFilterSuite`.
Secondly, I originally wanted to add `OrcFilterSuite` separately in order
to test actual filter evaluation (using the enums in `ExpressionTree.Operator`
and `PredicateLeaf.Operator` at hive); however, I decided not to do it here (I
will do in a separate issue or followup PR) and just let the original test way
work properly first.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
