Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/11568#discussion_r55406003 --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala --- @@ -351,7 +351,16 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable with Logging { def getAppId: String = get("spark.app.id") /** Does the configuration contain a given parameter? */ - def contains(key: String): Boolean = settings.containsKey(key) + def contains(key: String): Boolean = { + if (settings.containsKey(key)) { --- End diff -- It always bothers me when I see `if (true) true`. I think `settings.containsKey(key) || ...`
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org