Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/11802#discussion_r57455819
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -246,9 +246,7 @@ class StreamingContext private[streaming] (
checkpointDir != null
}
- private[streaming] def initialCheckpoint: Checkpoint = {
- if (isCheckpointPresent) _cp else null
- }
+ private[streaming] def initialCheckpoint: Checkpoint = _cp
--- End diff --
Sorry @srowen to keep you waiting. As to the line, look at
`isCheckpointPresent` and see that it does what the `if...else` block does,
i.e. checks whether `_cp` is `null` and if it is, it returns `false` so `null`.
It's a false check here and hence an easy fix (and that's why I proposed it
with the other changes).
I can revert it and report another change if you want. Let me know.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
