Github user wangmiao1981 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11945#discussion_r57545765
--- Diff: python/pyspark/ml/tests.py ---
@@ -655,6 +656,20 @@ def test_nested_pipeline_persistence(self):
except OSError:
pass
+ def test_write_property(self):
+ lr = LinearRegression(maxIter=1)
+ path = tempfile.mkdtemp()
+ lr_path = path + "/lr"
+ lr.write.save(lr_path)
--- End diff --
I added similar test before. However, that test doesn't capture the change
in the inherit class (i.e., missing adding property in inherit class) and Yanbo
suggested adding a concrete test for testing the functionality. Let me know
your final decision. Thanks!
Miao
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
