Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/12469#discussion_r60092525 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala --- @@ -38,8 +38,6 @@ import org.apache.spark.sql.types._ /** * Represents a numeric vector, whose index type is Int and value type is Double. - * - * Note: Users should not implement this interface. --- End diff -- That's my point with the change. If uses should not implement this interface, we should offer them alternatives. Do you know any? I'm happy to add it to the scaladoc.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org