Github user wangmiao1981 commented on a diff in the pull request: https://github.com/apache/spark/pull/12402#discussion_r60290299 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/GaussianMixture.scala --- @@ -105,6 +108,15 @@ class GaussianMixtureModel private[ml] ( def gaussians: Array[MultivariateGaussian] = parentModel.gaussians @Since("2.0.0") --- End diff -- @jkbradley I changed the gaussians return value as DataFrame and it works for python side. Now I change the related scala side which directly uses gaussians. There are two places in the test and one place in the saveImpl function. I will submit the code for review. I think if we can keep two methods, one is the original gaussians, the other is the Dataframe API for Python, the code could be simpler. Now, I just use one method.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org