Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/12666#discussion_r60991107
--- Diff: core/src/main/scala/org/apache/spark/scheduler/Pool.scala ---
@@ -55,6 +55,8 @@ private[spark] class Pool(
new FairSchedulingAlgorithm()
case SchedulingMode.FIFO =>
new FIFOSchedulingAlgorithm()
+ case _ =>
+ throw new RuntimeException(s"The scheduler mode $schedulingMode is
not supported by Spark.")
--- End diff --
In
[TaskSchedulerImpl](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala#L118)
they use: "Unrecognized spark.scheduler.mode: $schedulingModeConf" so I'd
change it to "Unsupported spark.scheduler.mode: $schedulingMode".
I'm also not sure about the other places like
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala#L133-L138.
I know that the change would not let it be executed with `NONE` or unsupported
scheduling modes, but when Pool changes...just thinking aloud.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
