Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/12718#discussion_r61494448
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala ---
@@ -79,11 +79,12 @@ final class ChiSqSelector(override val uid: String)
@Since("2.0.0")
override def fit(dataset: Dataset[_]): ChiSqSelectorModel = {
+ val sqlContext = dataset.sqlContext
+ import sqlContext.implicits._
+
transformSchema(dataset.schema, logging = true)
- val input = dataset.select($(labelCol), $(featuresCol)).rdd.map {
- case Row(label: Double, features: Vector) =>
- LabeledPoint(label, features)
- }
+ val input =
dataset.select(col($(labelCol)).cast(DoubleType).as("label"),
--- End diff --
Sorry, couldn't resist :) I'd change `"label"` to be a symbol `'label`. Not
very widely used, but think it deserves its place in the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
