Github user jaceklaskowski commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13210#discussion_r63987667
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala
 ---
    @@ -55,10 +55,19 @@ object UnsupportedOperationChecker {
             case _: InsertIntoTable =>
               throwError("InsertIntoTable is not supported with streaming 
DataFrames/Datasets")
     
    -        case Aggregate(_, _, child) if child.isStreaming && outputMode == 
Append =>
    -          throwError(
    -            "Aggregations are not supported on streaming 
DataFrames/Datasets in " +
    -              "Append output mode. Consider changing output mode to 
Update.")
    +        case Aggregate(_, _, child) if child.isStreaming =>
    +          if (outputMode == Append) {
    +            throwError(
    +              "Aggregations are not supported on streaming 
DataFrames/Datasets in " +
    +                "Append output mode. Consider changing output mode to 
Update.")
    +          }
    +          val moreStreamingAggregates = child.find {
    +            case Aggregate(_, _, grandchild) if grandchild.isStreaming => 
true
    +            case _ => false
    +          }
    +          if (moreStreamingAggregates.nonEmpty) {
    +            throwError("Multiple streaming aggregations are not supported 
DataFrames/Datasets")
    --- End diff --
    
    "are not supported DataFrames/Datasets"? It appears as "in" or "for" might 
be missing?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to