Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/13329#issuecomment-222140528
The issue with `nonEmpty` is that you could easily miss the negation (and
that's why Scala offers `nonEmpty`). I don't think it's the final solution, but
certainly believe it's far better for future readers to know what's going on in
these lines. I believe the changes improve readability (but can happily revert
_some_ if you point me at the places that need this).
It's just me to believe that by doing these small changes the code becomes
more readable. I spent enough time with it to think it needs so (more often
than I'm proposing).
Please guide me to learn your coding style. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
