Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13368#discussion_r64979724
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
 ---
    @@ -290,11 +290,6 @@ object TypeCoercion {
           // Skip nodes who's children have not been resolved yet.
           case e if !e.childrenResolved => e
     
    -      case a @ BinaryArithmetic(left @ StringType(), right @ 
DecimalType.Expression(_, _)) =>
    -        a.makeCopy(Array(Cast(left, DecimalType.SYSTEM_DEFAULT), right))
    -      case a @ BinaryArithmetic(left @ DecimalType.Expression(_, _), right 
@ StringType()) =>
    -        a.makeCopy(Array(left, Cast(right, DecimalType.SYSTEM_DEFAULT)))
    -
    --- End diff --
    
    Hi, @dilipbiswal .
    IMHO, the root cause seems to be **decimal multiplication** between 
`decimal(38,18)`s.
    ```
    scala> sql("select cast(10 as decimal(38,18)) * cast(10 as 
decimal(38,18))").head
    res0: org.apache.spark.sql.Row = [null]
    ```
    How do you think about this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to