Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13392#discussion_r65008333
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -937,7 +937,8 @@ object SimplifyConditionals extends Rule[LogicalPlan]
with PredicateHelper {
*/
case class OptimizeCodegen(conf: CatalystConf) extends Rule[LogicalPlan] {
def apply(plan: LogicalPlan): LogicalPlan = plan transformAllExpressions
{
- case e @ CaseWhen(branches, _) if branches.size <
conf.maxCaseBranchesForCodegen =>
+ case e @ CaseWhen(branches, elseBranch)
+ if branches.size + elseBranch.size <=
conf.maxCaseBranchesForCodegen =>
--- End diff --
Reading the case takes a while and and I think it'd greatly benefit from
introducing a local `def` - a predicate - for the condition (I can't figure out
a name for this, sorry)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
