Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12850#discussion_r65127553
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -751,6 +751,16 @@ object ConstantFolding extends Rule[LogicalPlan] {
// Fold expressions that are foldable.
case e if e.foldable => Literal.create(e.eval(EmptyRow), e.dataType)
+
+ // Use associative property for integral type
+ case e if e.isInstanceOf[BinaryArithmetic] &&
e.dataType.isInstanceOf[IntegralType]
+ => e match {
+ case Add(Add(a, b), c) if b.foldable && c.foldable => Add(a,
Add(b, c))
--- End diff --
Thank you for review, @cloud-fan !
I see. That sounds great.
Let me think about how to eliminate all constants then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
