Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12850#discussion_r65237290
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -742,6 +742,23 @@ object InferFiltersFromConstraints extends
Rule[LogicalPlan] with PredicateHelpe
* equivalent [[Literal]] values.
*/
object ConstantFolding extends Rule[LogicalPlan] {
+ private def isAssociativelyFoldable(e: Expression): Boolean =
--- End diff --
Oh, that could be.
There is some difference on level of granulity.
Join-related optimizers might be improved later to cost-based optimizers
while ConstantFolder optimizer is just about removing constants on a single
expression.
Do you think it is a good idea to put the different levels of concerns
together?
I can do this in any way you decide. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
