Github user jaceklaskowski commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13513#discussion_r65825524
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -529,7 +529,28 @@ object SQLConf {
           .internal()
           .doc("How long in milliseconds a file is guaranteed to be visible 
for all readers.")
           .timeConf(TimeUnit.MILLISECONDS)
    -      .createWithDefault(60 * 1000L) // 10 minutes
    +      .createWithDefault(60 * 10 * 1000L) // 10 minutes
    +
    +  val FILE_SOURCE_LOG_DELETION = 
SQLConfigBuilder("spark.sql.streaming.fileSource.log.deletion")
    +    .internal()
    +    .doc("Whether to delete the expired log files in file stream source.")
    +    .booleanConf
    +    .createWithDefault(true)
    +
    +  val FILE_SOURCE_LOG_COMPACT_INTERVAL =
    +    SQLConfigBuilder("spark.sql.streaming.fileSource.log.compactInterval")
    +      .internal()
    +      .doc("Number of log files after which all the previous files " +
    +        "are compacted into the next log file.")
    +      .intConf
    +      .createWithDefault(10)
    +
    +  val FILE_SOURCE_LOG_CLEANUP_DELAY =
    +    SQLConfigBuilder("spark.sql.streaming.fileSource.log.cleanupDelay")
    +      .internal()
    +      .doc("How long in milliseconds a file is guaranteed to be visible 
for all readers.")
    +      .timeConf(TimeUnit.MILLISECONDS)
    +      .createWithDefault(60 * 10 * 1000L) // 10 minutes
    --- End diff --
    
    A nitpick but think it'd be easier to "decode" - `10 * 60 * 1000L`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to